[DERBY-2920] Share code between readExternal() and readExternalFromArray()

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 10.10.1.1
• Component/s: Services, SQL
• Labels: derby_triage10_10
• Urgency: Normal
• Assignee: Knut Anders Hatlen
• Reporter: Knut Anders Hatlen
• Created: 11/Jul/07 08:00
• Updated: 19/Nov/12 13:23
• Resolved: 19/Nov/12 13:23

Description

Most of the implementations of DataValueDescriptor.readExternalFromArray(ArrayInputStream) are identical to their corresponding Externalizable.readExternal(ObjectInput) methods. Since ArrayInputStream implements ObjectInput, readExternalFromArray() could in those cases just have forwarded calls to readExternal() instead of duplicating the code. A default forwarding implementation of readExternalFromArray() could be placed in org.apache.derby.iapi.types.DataType, and all the existing implementations, except those with optimizations for ArrayInputStream, could be removed.

Issue Links

• is related to: DERBY-5971 Improve test coverage for SQLBoolean class