Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-2920

Share code between readExternal() and readExternalFromArray()

    Details

    • Urgency:
      Normal

      Description

      Most of the implementations of DataValueDescriptor.readExternalFromArray(ArrayInputStream) are identical to their corresponding Externalizable.readExternal(ObjectInput) methods. Since ArrayInputStream implements ObjectInput, readExternalFromArray() could in those cases just have forwarded calls to readExternal() instead of duplicating the code. A default forwarding implementation of readExternalFromArray() could be placed in org.apache.derby.iapi.types.DataType, and all the existing implementations, except those with optimizations for ArrayInputStream, could be removed.

        Attachments

        1. ReadInts2.java
          3 kB
          Knut Anders Hatlen
        2. ReadInts.java
          3 kB
          Knut Anders Hatlen
        3. d2920-2a-unused.diff
          6 kB
          Knut Anders Hatlen
        4. d2920-1a.diff
          26 kB
          Knut Anders Hatlen

          Issue Links

            Activity

              People

              • Assignee:
                knutanders Knut Anders Hatlen
                Reporter:
                knutanders Knut Anders Hatlen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: