Derby
  1. Derby
  2. DERBY-2841

Convert jdbcapi/nullSQLText.java to JUnit

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 10.3.1.4
    • Fix Version/s: 10.5.1.1
    • Component/s: Test
    • Labels:
      None
    1. DERBY-2841.diff-062007
      30 kB
      Ramin Moazeni
    2. DERBY-2841.stat-062007
      0.8 kB
      Ramin Moazeni
    3. DERBY-2841.diff-062607
      31 kB
      Ramin Moazeni
    4. DERBY-2841.stat-062607
      0.8 kB
      Ramin Moazeni
    5. DERBY-2841v2.diff
      31 kB
      Ramin Moazeni

      Activity

      Hide
      Kathey Marsden added a comment -

      Looks like this was committed some time ago. Resolving the issue.

      Show
      Kathey Marsden added a comment - Looks like this was committed some time ago. Resolving the issue.
      Hide
      Ramin Moazeni added a comment -

      Hi Kathey

      Thanks for your review. I am attaching another patch
      which I think addresses your review comment. Your
      review is appreciated.

      Thanks
      Ramin

      Show
      Ramin Moazeni added a comment - Hi Kathey Thanks for your review. I am attaching another patch which I think addresses your review comment. Your review is appreciated. Thanks Ramin
      Hide
      Kathey Marsden added a comment -

      Hi Ramin,

      Forgive me if I missed these comments the first time around, but I noticed two small things.
      1) In general we are not using the procedures in ProcedureTest but rather adding methods to the new test (NullSQLText)
      stmt.execute("create procedure za() language java external name " +
      "'org.apache.derbyTesting.functionTests.util.ProcedureTest.zeroArg'" +
      " parameter style java");

      2) We don't need to support JCC so the references to TestUtil.isJCCFramework() can be removed.

      Show
      Kathey Marsden added a comment - Hi Ramin, Forgive me if I missed these comments the first time around, but I noticed two small things. 1) In general we are not using the procedures in ProcedureTest but rather adding methods to the new test (NullSQLText) stmt.execute("create procedure za() language java external name " + "'org.apache.derbyTesting.functionTests.util.ProcedureTest.zeroArg'" + " parameter style java"); 2) We don't need to support JCC so the references to TestUtil.isJCCFramework() can be removed.
      Hide
      Ramin Moazeni added a comment -

      Hi Kathey

      Thanks for your comments and review. I am attaching
      another patch that addresses your comments/review.

      Your comments/review is appreciated.

      Thanks,
      Ramin

      Show
      Ramin Moazeni added a comment - Hi Kathey Thanks for your comments and review. I am attaching another patch that addresses your comments/review. Your comments/review is appreciated. Thanks, Ramin
      Hide
      Kathey Marsden added a comment -

      Hi Ramin,

      I think that instead of testCommentStmtValue it would be good to use
      JDBC.assertFullResultSet. Also it would be good to cleanup the imports. Other than that it looks good.
      Please check patch available when you post the new patch.

      Thanks

      Kathey

      Show
      Kathey Marsden added a comment - Hi Ramin, I think that instead of testCommentStmtValue it would be good to use JDBC.assertFullResultSet. Also it would be good to cleanup the imports. Other than that it looks good. Please check patch available when you post the new patch. Thanks Kathey
      Hide
      Ramin Moazeni added a comment -

      Here I am attaching the patch that converts the jdbcapi/nullSQLText to Junit.
      Your feedback and review is appreciated.

      Please note that suites.All and derbyall both finished without any failures.

      Show
      Ramin Moazeni added a comment - Here I am attaching the patch that converts the jdbcapi/nullSQLText to Junit. Your feedback and review is appreciated. Please note that suites.All and derbyall both finished without any failures.

        People

        • Assignee:
          Ramin Moazeni
          Reporter:
          Ramin Moazeni
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development