Derby
  1. Derby
  2. DERBY-2726

convert lang/AIjdbc.java to JUnit

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.3.1.4
    • Component/s: Test
    • Labels:
      None
    1. DERBY-2726_stat_290507.txt
      0.2 kB
      Ugo Matrangolo
    2. DERBY-2726_stat_090607.txt
      0.3 kB
      Ugo Matrangolo
    3. DERBY-2726_diff_290507.txt
      4 kB
      Ugo Matrangolo
    4. DERBY-2726_diff_090607.txt
      10 kB
      Ugo Matrangolo

      Activity

      Hide
      Kathey Marsden added a comment -

      committed to trunk with revision 546644.

      Show
      Kathey Marsden added a comment - committed to trunk with revision 546644.
      Hide
      Ugo Matrangolo added a comment -

      Thanks Kathey for your comments.

      I modified the code accordingly (I hope ).

      Please check if the package where I placed the new test is correct and if the test configuration is correct. The rest of the code is untouched.

      Please review,
      – Ugo.

      Show
      Ugo Matrangolo added a comment - Thanks Kathey for your comments. I modified the code accordingly (I hope ). Please check if the package where I placed the new test is correct and if the test configuration is correct. The rest of the code is untouched. Please review, – Ugo.
      Hide
      Kathey Marsden added a comment -

      Uncheck patch available since there are review comments that need to be incorporated.

      Show
      Kathey Marsden added a comment - Uncheck patch available since there are review comments that need to be incorporated.
      Hide
      Kathey Marsden added a comment -

      Thanks Ugo for converting the test.
      The mention of EMBEDDED on the Wiki page means that the old test is running in LangHarnessJavaTest only in embedded mode. It should be removed from org.apache.derbyTesting.functionTests.tests.lang.LangHarnessJavaTest now that you are adding the new test. Also the old file AIjdbc.java should be removed.

      I think it would be good to run this test in client mode as well to get coverage for the client driver for these ResultSetMetaData methods. I also think it would be good to move the test to the jdbc suite from lang.
      I think it was in the wrong suite to start with. It would be nice to have some javadoc, but otherwise your test looks good to me.

      Show
      Kathey Marsden added a comment - Thanks Ugo for converting the test. The mention of EMBEDDED on the Wiki page means that the old test is running in LangHarnessJavaTest only in embedded mode. It should be removed from org.apache.derbyTesting.functionTests.tests.lang.LangHarnessJavaTest now that you are adding the new test. Also the old file AIjdbc.java should be removed. I think it would be good to run this test in client mode as well to get coverage for the client driver for these ResultSetMetaData methods. I also think it would be good to move the test to the jdbc suite from lang. I think it was in the wrong suite to start with. It would be nice to have some javadoc, but otherwise your test looks good to me.
      Hide
      Ugo Matrangolo added a comment -

      Initial draft of the conversion of this test.

      I'm unsure on how I handled the fact that the test is tagged as EMBEDDED on the wiki page; please, confirm my code.

      Please review,
      Ugo.

      Show
      Ugo Matrangolo added a comment - Initial draft of the conversion of this test. I'm unsure on how I handled the fact that the test is tagged as EMBEDDED on the wiki page; please, confirm my code. Please review, Ugo.

        People

        • Assignee:
          Ugo Matrangolo
          Reporter:
          Ugo Matrangolo
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development