Derby
  1. Derby
  2. DERBY-2497

convert lang/coalesceTests.java to junit

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.3.1.4
    • Component/s: Test
    • Labels:
      None

      Description

      convert lang/coalesceTests.java to junit

      1. DERBY_2497.diff
        95 kB
        Ramandeep Kaur

        Activity

        Hide
        Ramandeep Kaur added a comment -

        I am attaching patch for conversion of lang/coalesceTests.java to junit test "CoalesceTestsTest.java". Please provide your feedback.

        Show
        Ramandeep Kaur added a comment - I am attaching patch for conversion of lang/coalesceTests.java to junit test "CoalesceTestsTest.java". Please provide your feedback.
        Hide
        Myrna van Lunteren added a comment -

        Patch & test look good to me, on the whole, I have only minor fuzzes:

        • I don't much like the name, I'd prefer CoalesceTest over CoalesceTestsTest.
        • whitespace differences in the resultDataTypeRulesTable
        • some more whitespace issues.

        I'll take another look later, i.e. this evening, or tomorrow morning, and make those minor changes before checking in.

        Did you run suites.All?

        Show
        Myrna van Lunteren added a comment - Patch & test look good to me, on the whole, I have only minor fuzzes: I don't much like the name, I'd prefer CoalesceTest over CoalesceTestsTest. whitespace differences in the resultDataTypeRulesTable some more whitespace issues. I'll take another look later, i.e. this evening, or tomorrow morning, and make those minor changes before checking in. Did you run suites.All?
        Hide
        Myrna van Lunteren added a comment -

        I renamed the test to CoalesceTest, and replaced all tabs with spaces. Also removed an unused import. Then removed coalesceTests.java and master, removed it from derbylang.runall.

        Ran derbyall and suites.All; there were no new failures.

        Committed. Thx Raman.

        Show
        Myrna van Lunteren added a comment - I renamed the test to CoalesceTest, and replaced all tabs with spaces. Also removed an unused import. Then removed coalesceTests.java and master, removed it from derbylang.runall. Ran derbyall and suites.All; there were no new failures. Committed. Thx Raman.

          People

          • Assignee:
            Ramandeep Kaur
            Reporter:
            Ramandeep Kaur
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development