Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.3.1.4
    • Fix Version/s: 10.4.1.3
    • Component/s: Test
    • Labels:
      None
    1. derby-2484-v1.diff
      734 kB
      Andrew McIntyre

      Activity

      Hide
      Andrew McIntyre added a comment -

      Attaching converted syscat.sql. The only checks not retained by the conversion are for the column numbers and datatypes of each column in the system tables, as was implicitly done by listing them out in the old canon-based test. If someone feels the column numbers and datatypes for each column should be checked by the test, I will look into implementing it, otherwise I will commit this test and move on.

      Show
      Andrew McIntyre added a comment - Attaching converted syscat.sql. The only checks not retained by the conversion are for the column numbers and datatypes of each column in the system tables, as was implicitly done by listing them out in the old canon-based test. If someone feels the column numbers and datatypes for each column should be checked by the test, I will look into implementing it, otherwise I will commit this test and move on.
      Hide
      Andrew McIntyre added a comment -

      Decided to go ahead and keep the checks for column number and datatype in testSystemCatalogColumns(). Committed to trunk with revision 522772.

      Show
      Andrew McIntyre added a comment - Decided to go ahead and keep the checks for column number and datatype in testSystemCatalogColumns(). Committed to trunk with revision 522772.
      Hide
      Daniel John Debrunner added a comment -

      Fixture SystemCatalogTest.testNoUserDDLOnSystemTables() has incorrectly coded try/catch blocks. If a SQL statement incorrectly succeeds the test will pass instead of failing. The test could use utility methods instead of try/catch blocks.

      Show
      Daniel John Debrunner added a comment - Fixture SystemCatalogTest.testNoUserDDLOnSystemTables() has incorrectly coded try/catch blocks. If a SQL statement incorrectly succeeds the test will pass instead of failing. The test could use utility methods instead of try/catch blocks.
      Hide
      Andrew McIntyre added a comment -

      Changed fixture testNoUserDDLOnSystemTables to use assertStatementError with revision 603855.

      Show
      Andrew McIntyre added a comment - Changed fixture testNoUserDDLOnSystemTables to use assertStatementError with revision 603855.

        People

        • Assignee:
          Andrew McIntyre
          Reporter:
          Andrew McIntyre
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development