Derby
  1. Derby
  2. DERBY-2476

convert lang/forbitdata.java test to junit test

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.3.1.4
    • Component/s: Test
    • Labels:
      None

      Description

      Convert lang/forbitdata.java test to junit test

      1. DERBY_2476.diff
        50 kB
        Ramandeep Kaur
      2. DERBY_2476_0329.diff
        50 kB
        Ramandeep Kaur

        Activity

        Ramandeep Kaur created issue -
        Ramandeep Kaur made changes -
        Field Original Value New Value
        Assignee Ramandeep Kaur [ ramand ]
        Hide
        Ramandeep Kaur added a comment -

        I am attaching patch for conversion of forbitdata.java to junit test "ForBitDataTest.java". I mostly did line by line conversion for this test. I will look forward for any comments for improvements.

        Show
        Ramandeep Kaur added a comment - I am attaching patch for conversion of forbitdata.java to junit test "ForBitDataTest.java". I mostly did line by line conversion for this test. I will look forward for any comments for improvements.
        Ramandeep Kaur made changes -
        Attachment DERBY_2476.diff [ 12354347 ]
        Hide
        Andrew McIntyre added a comment -

        The new test looks good, one minor comment:

        Instead of putting handling the creation and removal of database tables in the setup and teardown methods, most tests have been rewritten with a suite() method that wraps the tests in the class in a CleanDatabaseTestSetup decorator. See tests/lang/GroupByExpressionTest.java for a good example of a suite method that uses CleanDatabaseTestSetup.

        Show
        Andrew McIntyre added a comment - The new test looks good, one minor comment: Instead of putting handling the creation and removal of database tables in the setup and teardown methods, most tests have been rewritten with a suite() method that wraps the tests in the class in a CleanDatabaseTestSetup decorator. See tests/lang/GroupByExpressionTest.java for a good example of a suite method that uses CleanDatabaseTestSetup.
        Hide
        Ramandeep Kaur added a comment -

        Hi Andrew, thanks for your comments.
        I have changed the test files to incorporate your comments.

        Thanks, Raman

        Show
        Ramandeep Kaur added a comment - Hi Andrew, thanks for your comments. I have changed the test files to incorporate your comments. Thanks, Raman
        Ramandeep Kaur made changes -
        Attachment DERBY_2476_0329.diff [ 12354560 ]
        Hide
        Andrew McIntyre added a comment -

        Committed to trunk with revision 524933.

        Show
        Andrew McIntyre added a comment - Committed to trunk with revision 524933.
        Andrew McIntyre made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Dag H. Wanvik made changes -
        Issue Type Test [ 6 ] Improvement [ 4 ]
        Kathey Marsden made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Gavin made changes -
        Workflow jira [ 12400129 ] Default workflow, editable Closed status [ 12797163 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        11d 23h 16m 1 Andrew McIntyre 02/Apr/07 22:41
        Resolved Resolved Closed Closed
        1389d 20h 8m 1 Kathey Marsden 21/Jan/11 17:49

          People

          • Assignee:
            Ramandeep Kaur
            Reporter:
            Ramandeep Kaur
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development