Derby
  1. Derby
  2. DERBY-2429

Convert jdbcapi/resultset.java to JUnit

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.3.1.4
    • Component/s: Test
    • Labels:
      None
    • Environment:
      Convert jdbcapi/resultset.java to JUnit
    1. DERBY_2429.diff
      86 kB
      Kathey Marsden

      Activity

      Hide
      Kathey Marsden added a comment -

      For converting this test I am taking the following strategy

      Tests to be migrated to new test: ResultSetMiscTest

      • Tests of metadata on columns of different types.
      • Tests of correlationnames and metadata calls.
      • Tests of autocommit behaviour
      • Test for Float.MAX_VALUE behaviour

      Tests to be removed

      • Test getXXX calls on different data types. This is already covered in ParameterMappingTest.java so I won't convert.

      Tests to be moved

      • Tests for mixed type NULLIF statements will be moved to CastingTest.java as it already has tables for comparison checking.

      Please let me know if does not seem a reasonable strategy.

      Show
      Kathey Marsden added a comment - For converting this test I am taking the following strategy Tests to be migrated to new test: ResultSetMiscTest Tests of metadata on columns of different types. Tests of correlationnames and metadata calls. Tests of autocommit behaviour Test for Float.MAX_VALUE behaviour Tests to be removed Test getXXX calls on different data types. This is already covered in ParameterMappingTest.java so I won't convert. Tests to be moved Tests for mixed type NULLIF statements will be moved to CastingTest.java as it already has tables for comparison checking. Please let me know if does not seem a reasonable strategy.
      Hide
      Kathey Marsden added a comment -

      Attached is the patch for this issue.

      Tests migrated to new test: ResultSetMiscTest

      • Tests of metadata on columns of different types.
      • Tests of correlationnames and metadata calls.
      • Tests of autocommit behaviour
      • Test for Float.MAX_VALUE behaviour

      Tests removed

      • Test getXXX calls on different data types. This is already covered in ParameterMappingTest.java so I won't convert.

      Tests moved

      • Tests for mixed type NULLIF statements will be moved to new test NullIfTest.java. Dan suggested I just reference the tableg in Casting.java instead of making a copy.
      Show
      Kathey Marsden added a comment - Attached is the patch for this issue. Tests migrated to new test: ResultSetMiscTest Tests of metadata on columns of different types. Tests of correlationnames and metadata calls. Tests of autocommit behaviour Test for Float.MAX_VALUE behaviour Tests removed Test getXXX calls on different data types. This is already covered in ParameterMappingTest.java so I won't convert. Tests moved Tests for mixed type NULLIF statements will be moved to new test NullIfTest.java. Dan suggested I just reference the tableg in Casting.java instead of making a copy.
      Hide
      Kathey Marsden added a comment -

      removed resultset.java and replaced with ResultSetMiscTest.java and NullIfTest.java

      Show
      Kathey Marsden added a comment - removed resultset.java and replaced with ResultSetMiscTest.java and NullIfTest.java
      Hide
      Myrna van Lunteren added a comment -

      removed left-over resultset_app.properties with revision 526828.

      Show
      Myrna van Lunteren added a comment - removed left-over resultset_app.properties with revision 526828.

        People

        • Assignee:
          Kathey Marsden
          Reporter:
          Kathey Marsden
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development