[DERBY-2412] Refactor NetworkServerControlImpl

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: Network Server
• Assignee: Unassigned
• Reporter: Bernt Johnsen
• Created: 07/Mar/07 12:21
• Updated: 15/Oct/08 02:54

Description

NetworkServerControlImpl is overly complex and serves several purposes. This makes it hard to penetrate the logic, to debug and to maintain.

I propose (actually, I've alread done a whole lot) to tear it apart and move the current semantics into the following new classes:
NetworkServer - the actual network server code
NetworkAdminServer - the implementation of network administration commands (ping, shutdown etc)
NetworkAdminClient - the client for network administration of Derby
NetworkAdminProtocol - the administration command protocol (as opposed to the DRDA protocol)
plus a couple of utility classes (common methods, common constants, error messaging, exceptions etc)

Issue Links

• blocks: DERBY-2363 Add initial handshake on connection setup to determine server's required ssl support level and avoid client side attribute settings.
• relates to: DERBY-2761 When maxthreads and timeslice is set, network server admin commands like shutdown etc. are not guaranteed to get through
• relates to: DERBY-2933 When network server disconnects due to an I/O Exception it does not always log the exception that caused the error
• relates to: DERBY-1465 NetworkServerControl.start() should throw an exception and not just print exceptions if the server fails to start