Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.6.1.0
    • Component/s: Test
    • Labels:
      None
    • Issue & fix info:
      Newcomer

      Description

      Replace its use with vmSupportsJDBC3() when required or modify the checks to work upon the assumption that JDBC3/JSR169 is the base level (e..g holdability is always supported).

      1. removeFunction.diff
        8 kB
        Bryan Pendleton

        Activity

        Hide
        Andrew McIntyre added a comment -

        [JDK13CLEANUP]

        I've been marking bugs with that tag in comments to make it easy to query JIRA for tasks related to removing JDK 1.3.1 support. I'll be glad to continue that habit if others find it useful.

        Show
        Andrew McIntyre added a comment - [JDK13CLEANUP] I've been marking bugs with that tag in comments to make it easy to query JIRA for tasks related to removing JDK 1.3.1 support. I'll be glad to continue that habit if others find it useful.
        Hide
        Bryan Pendleton added a comment -

        I had a quick look at the 15 remaining calls to vmSupportsJDBC2, and they seemed to be:

        • test code that needed to know if DriverManager was supported
        • test code that needed to know if BigDecimal was supported
        • test code that needed to know if [get,set]UnicodeStream was supported

        I believe that all these calls can simply be replaced by calling vmSupportsJDBC3,
        and then vmSupportsJDBC2 can be removed.

        Show
        Bryan Pendleton added a comment - I had a quick look at the 15 remaining calls to vmSupportsJDBC2, and they seemed to be: test code that needed to know if DriverManager was supported test code that needed to know if BigDecimal was supported test code that needed to know if [get,set] UnicodeStream was supported I believe that all these calls can simply be replaced by calling vmSupportsJDBC3, and then vmSupportsJDBC2 can be removed.
        Hide
        Bryan Pendleton added a comment -

        Attached 'removeFunction.diff' is a patch proposal to remove vmSupportsJDBC2()
        from the codeline and replace the 15-or-so current calls to that function by calling
        vmSupportsJDBC3() instead.

        A full regression test run in my environment was clean.

        It seems like this patch introduces the most risk in the area of JSR169 testing.
        Is there anyone who has a JSR169-based test environment who can perform
        a regression test run with this patch, or give it a quick code review, before I commit it?

        thanks,

        bryan

        Show
        Bryan Pendleton added a comment - Attached 'removeFunction.diff' is a patch proposal to remove vmSupportsJDBC2() from the codeline and replace the 15-or-so current calls to that function by calling vmSupportsJDBC3() instead. A full regression test run in my environment was clean. It seems like this patch introduces the most risk in the area of JSR169 testing. Is there anyone who has a JSR169-based test environment who can perform a regression test run with this patch, or give it a quick code review, before I commit it? thanks, bryan
        Hide
        Knut Anders Hatlen added a comment -

        Looks safe to me. +1 to commit. I'm sure we'll find out soon enough if it breaks!

        I haven't tested it in a JSR169-based environment, but given that vmSupportJDBC3() is a stricter check (HAVE_DRIVER && HAVE_SAVEPOINT vs only HAVE_DRIVER), no tests that were not run before should start running after the change, so JSR169 should be unaffected as far as I can see.

        Show
        Knut Anders Hatlen added a comment - Looks safe to me. +1 to commit. I'm sure we'll find out soon enough if it breaks! I haven't tested it in a JSR169-based environment, but given that vmSupportJDBC3() is a stricter check (HAVE_DRIVER && HAVE_SAVEPOINT vs only HAVE_DRIVER), no tests that were not run before should start running after the change, so JSR169 should be unaffected as far as I can see.
        Hide
        Bryan Pendleton added a comment -

        Thanks Knut for having a look at the patch. Committed to the trunk as revision 883000.

        Please keep your eyes out for any new test behaviors, particularly in JSR169 configurations.

        Show
        Bryan Pendleton added a comment - Thanks Knut for having a look at the patch. Committed to the trunk as revision 883000. Please keep your eyes out for any new test behaviors, particularly in JSR169 configurations.

          People

          • Assignee:
            Bryan Pendleton
            Reporter:
            Daniel John Debrunner
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development