Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.2.1.6
    • Fix Version/s: 10.2.1.6
    • Component/s: JDBC
    • Labels:
      None

      Description

      JDBC 4.0 introduced the java.sql.RowId interface. Derby has implemented this interface both in the client driver and the embedded driver, but the methods only throw java.lang.UnsupportedOperationException, and an application has no way to get a RowId object. To reduce the footprint, these unused classes should be removed.

      1. rowid.diff
        8 kB
        Knut Anders Hatlen
      2. rowid.stat
        0.3 kB
        Knut Anders Hatlen

        Activity

        Hide
        Knut Anders Hatlen added a comment -

        Attached a patch which removes org.apache.derby.impl.jdbc.EmbedRowId and org.apache.derby.client.am.RowId. Derbyall ran cleanly on jdk1.6 (except TestQueryObject which fails because of a bug in the jdk).

        Show
        Knut Anders Hatlen added a comment - Attached a patch which removes org.apache.derby.impl.jdbc.EmbedRowId and org.apache.derby.client.am.RowId. Derbyall ran cleanly on jdk1.6 (except TestQueryObject which fails because of a bug in the jdk).
        Hide
        Daniel John Debrunner added a comment -

        Could the classes be left in the codeline and just excluded by the build?
        Do they even show up in the jar files? I would have thought not for embedded and I thought the client moved to a dependency build.

        Show
        Daniel John Debrunner added a comment - Could the classes be left in the codeline and just excluded by the build? Do they even show up in the jar files? I would have thought not for embedded and I thought the client moved to a dependency build.
        Hide
        Knut Anders Hatlen added a comment -

        EmbedRowId is in derby.jar because RowIdNotImplementedTest and Driver40 have a direct reference to it. The client class is not in derbyclient.jar. Since the classes have no functionality at all, I don't see much point in leaving them in the codeline. You could always restore them from subversion later.

        Show
        Knut Anders Hatlen added a comment - EmbedRowId is in derby.jar because RowIdNotImplementedTest and Driver40 have a direct reference to it. The client class is not in derbyclient.jar. Since the classes have no functionality at all, I don't see much point in leaving them in the codeline. You could always restore them from subversion later.
        Hide
        Knut Anders Hatlen added a comment -

        Committed revision 440321. Leaving the issue open until it has been merged to 10.2.

        Show
        Knut Anders Hatlen added a comment - Committed revision 440321. Leaving the issue open until it has been merged to 10.2.
        Hide
        Knut Anders Hatlen added a comment -

        Committed to 10.2 with revision 441540.

        Show
        Knut Anders Hatlen added a comment - Committed to 10.2 with revision 441540.

          People

          • Assignee:
            Knut Anders Hatlen
            Reporter:
            Knut Anders Hatlen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development