[DERBY-1734] Simplify building of SystemColumn array in CatalogRowFactory implementations.

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 10.4.1.3
• Component/s: SQL
• Assignee: Daniel John Debrunner
• Reporter: Daniel John Debrunner
• Created: 20/Aug/06 19:48
• Updated: 21/Nov/07 08:10
• Resolved: 31/Aug/07 23:48

Description

The implementations of CatalogRowFactory.buildColumnList() can be simplified in a number of ways:
1) precision & scale are always passed in as zero and can be removed
2) adding static factory methods to SystemColumnImpl would ease the building of the arrays by not requiring the additional redundant arguments the constructor call forces today, e.g. max length i snot required to create an INTEGER column.
3) The column's position is not required to be stored in the SytstemColumn class, it's defined by the position in the array

4) arrays can be built using
new SystemColumn[]

{ ... }

syntax instead of the existing
columnList[0] = ...
columnList[1] = ...

or

columnList[index++] = ...
columnList[index++] = ...