[DERBY-1700] Remove passing of closeCleanup method to every ResultSet type since only the top ResultSet requires it.

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 10.2.1.6, 10.3.1.4
• Component/s: SQL
• Assignee: Daniel John Debrunner
• Reporter: Daniel John Debrunner
• Created: 15/Aug/06 20:22
• Updated: 20/Mar/07 23:34
• Resolved: 22/Sep/06 19:03

Description

A UNION node will generate byte code to call this method:

NoPutResultSet getUnionResultSet(NoPutResultSet source1,
NoPutResultSet source2,
Activation activation,
int resultSetNumber,
double optimizerEstimatedRowCount,
double optimizerEstimatedCost,
GeneratedMethod closeCleanup)

The closeCleanup method is passed in as null for all result sets in a tree except the top one. Instead of passing it on each new result set, it would be much more efficient to have a setCloseMethod() that is only called once for the top result set. Could also look at having an closeCleanup method in the interface and call it directly, rather than through reflection.

This applies to any node that takes a closeCleanup method.

Split out from DERBY-766