Derby
  1. Derby
  2. DERBY-1698

Add more tests for Statement.setQueryTimeout method

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.2.1.6, 10.3.1.4
    • Fix Version/s: 10.2.1.6, 10.3.1.4
    • Component/s: Test
    • Labels:
      None

      Description

      Currently, the following checks work as expected but it would be good to add them to regression tests:

      • Add tests for Statement and CallableStatement class. Existing test tests this method with PreparedStatement only. I found a difference in behaviour with client driver when using Statement class (DERBY-1692). So it may be good to add some tests for each statement class.
      1. derby-1698.status
        0.3 kB
        Deepa Remesh
      2. derby-1698.diff
        2 kB
        Deepa Remesh

        Activity

        Gavin made changes -
        Workflow jira [ 12381802 ] Default workflow, editable Closed status [ 12799418 ]
        Dag H. Wanvik made changes -
        Issue Type Test [ 6 ] Improvement [ 4 ]
        Deepa Remesh made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Deepa Remesh made changes -
        Fix Version/s 10.3.0.0 [ 12310800 ]
        Fix Version/s 10.2.1.0 [ 11187 ]
        Mike Matrigali made changes -
        Derby Info [Patch Available]
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Hide
        Mike Matrigali added a comment -

        fixes applied to trunk and 10.2 branch, unchecking patch available and resolving.

        Show
        Mike Matrigali added a comment - fixes applied to trunk and 10.2 branch, unchecking patch available and resolving.
        Hide
        Mike Matrigali added a comment -

        back ported change from trunk to 10.2 branch:

        m102_142:26>svn commit

        Sending java\testing\org\apache\derbyTesting\functionTests\master\SetQueryTimeoutTest.out
        Sending java\testing\org\apache\derbyTesting\functionTests\tests\jdbcapi\SetQueryTimeoutTest.java
        Transmitting file data ..
        Committed revision 436977.

        Show
        Mike Matrigali added a comment - back ported change from trunk to 10.2 branch: m102_142:26>svn commit Sending java\testing\org\apache\derbyTesting\functionTests\master\SetQueryTimeoutTest.out Sending java\testing\org\apache\derbyTesting\functionTests\tests\jdbcapi\SetQueryTimeoutTest.java Transmitting file data .. Committed revision 436977.
        Hide
        Mike Matrigali added a comment -

        committed patch to the trunk:
        m3_142:172>svn commit

        Sending java\testing\org\apache\derbyTesting\functionTests\master\SetQueryTimeoutTest.out
        Sending java\testing\org\apache\derbyTesting\functionTests\tests\jdbcapi\SetQueryTimeoutTest.java
        Transmitting file data ..
        Committed revision 436904.

        Show
        Mike Matrigali added a comment - committed patch to the trunk: m3_142:172>svn commit Sending java\testing\org\apache\derbyTesting\functionTests\master\SetQueryTimeoutTest.out Sending java\testing\org\apache\derbyTesting\functionTests\tests\jdbcapi\SetQueryTimeoutTest.java Transmitting file data .. Committed revision 436904.
        Hide
        V.Narayanan added a comment -

        jdbcapi/SetQueryTimeoutTest.java was earlier being limited by DERBY-694 and is no more. Please find DERBY-705 related to this

        Show
        V.Narayanan added a comment - jdbcapi/SetQueryTimeoutTest.java was earlier being limited by DERBY-694 and is no more. Please find DERBY-705 related to this
        Deepa Remesh made changes -
        Derby Info [Patch Available]
        Deepa Remesh made changes -
        Attachment derby-1698.status [ 12339455 ]
        Attachment derby-1698.diff [ 12339454 ]
        Hide
        Deepa Remesh added a comment -

        Attaching a patch 'derby-1698.diff' which adds an additional test to jdbcapi/SetQueryTimeoutTest.java. This patch adds a test for executeUpdate method call. Other tests for Statement and CallableStatement class have been already added by Knut Anders.

        With this patch, I ran the test jdbcapi/SetQueryTimeoutTest.java with embedded and client framework. It is excluded in JCC framework.

        This is a small patch which modifies only tests. Please take a look and commit if okay. Thanks.

        Show
        Deepa Remesh added a comment - Attaching a patch 'derby-1698.diff' which adds an additional test to jdbcapi/SetQueryTimeoutTest.java. This patch adds a test for executeUpdate method call. Other tests for Statement and CallableStatement class have been already added by Knut Anders. With this patch, I ran the test jdbcapi/SetQueryTimeoutTest.java with embedded and client framework. It is excluded in JCC framework. This is a small patch which modifies only tests. Please take a look and commit if okay. Thanks.
        Deepa Remesh made changes -
        Field Original Value New Value
        Assignee Deepa Remesh [ deepa ]
        Deepa Remesh created issue -

          People

          • Assignee:
            Deepa Remesh
            Reporter:
            Deepa Remesh
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development