Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-1638

JUnit TestConfiguration class uses engine code to determine JDBC level.

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.2.1.6
    • Component/s: Test
    • Labels:
      None

      Description

      TestConfiguration uses the org.apache.derby.iapi.services.info.JVMInfo to determine if JDBC 4 is supported. Ideally test code should not be calling engine private api code.

      Suggest two changes:

      1) Determine JDBC level support from ability to load classes:
      E.g. JDBC2 - java.sql.Driver
      JDBC3 - java.sql.Driver AND java.sql.ParameterMetaData
      JDBC4 - java.sql.Driver AND java.sql.SQLXML
      JSR169 - java.sql.ParameterMetaData AND NOT java.sql.Driver

      2) Move the supportsJDBC4() method from TestConfiguraiton to JDBC, since if the VM supports JDBC4 or not is
      not an attribute of a test configuration (and add other supportsJDBCX methods).

        Attachments

        1. derby1638_diff.txt
          5 kB
          Daniel John Debrunner

          Activity

            People

            • Assignee:
              djd Daniel John Debrunner
              Reporter:
              djd Daniel John Debrunner
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: