Derby
  1. Derby
  2. DERBY-1163

Add jdbc4.0 implementation of EmbedPooledConnection and EmbedXAConnection

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.2.1.6
    • Component/s: JDBC
    • Labels:
      None
    • Environment:
      jdk1.6, jdbc4.0
    1. derby-1163_3.diff
      12 kB
      Anurag Shekhar
    2. derby-1163_2.diff
      14 kB
      Anurag Shekhar
    3. derby-1163.diff
      13 kB
      Anurag Shekhar

      Issue Links

        Activity

        Hide
        Andrew McIntyre added a comment -

        This issue has been resolved for over a year with no further movement. Closing.

        Show
        Andrew McIntyre added a comment - This issue has been resolved for over a year with no further movement. Closing.
        Hide
        Rick Hillegas added a comment -

        Derbyall runs cleanly under jdk1.4 (modulo the wisconsin noise) and the jdbc4 tests run cleanly too. Committed at subversion revision 393460.

        Show
        Rick Hillegas added a comment - Derbyall runs cleanly under jdk1.4 (modulo the wisconsin noise) and the jdbc4 tests run cleanly too. Committed at subversion revision 393460.
        Hide
        Anurag Shekhar added a comment -

        Changed EmbedXAConnection40 to extend from EmbedXAConnection to address the concern raised during review of derby-1137.
        Removed all copied methods and added the two new methods required by jdbc4.0

        reverted the changes made in the last patch in XAStatementControl

        Show
        Anurag Shekhar added a comment - Changed EmbedXAConnection40 to extend from EmbedXAConnection to address the concern raised during review of derby-1137. Removed all copied methods and added the two new methods required by jdbc4.0 reverted the changes made in the last patch in XAStatementControl
        Hide
        Rick Hillegas added a comment -

        Committed at subversion revision 391090.

        Show
        Rick Hillegas added a comment - Committed at subversion revision 391090.
        Hide
        Rick Hillegas added a comment -

        Looks good. The jdbc4 tests pass. Derbyall has the usual errors: wisconsin, sysinfo, and sysinfo_withproperties.

        Show
        Rick Hillegas added a comment - Looks good. The jdbc4 tests pass. Derbyall has the usual errors: wisconsin, sysinfo, and sysinfo_withproperties.
        Hide
        Anurag Shekhar added a comment -

        the privious patch broke due to changes made in EmbedPoolableConnection as part of DERBY-1158.
        I have fixed the problem. As the changes are only in 40 class which is unused for now I haven't reran derbyall

        Show
        Anurag Shekhar added a comment - the privious patch broke due to changes made in EmbedPoolableConnection as part of DERBY-1158 . I have fixed the problem. As the changes are only in 40 class which is unused for now I haven't reran derbyall
        Hide
        Rick Hillegas added a comment -

        I'm afraid I see the following build error:

        [javac] C:\cygwin\home\rh161140\derby\mainline\trunk\java\engine\org\apache\derby\jdbc\EmbedXAConnection40.java:97:
        checkHoldCursors(int,boolean) in org.apache.derby.jdbc.EmbedPooledConnection cannot be applied to (int)
        [javac] super.checkHoldCursors(holdability);
        [javac] ^

        Show
        Rick Hillegas added a comment - I'm afraid I see the following build error: [javac] C:\cygwin\home\rh161140\derby\mainline\trunk\java\engine\org\apache\derby\jdbc\EmbedXAConnection40.java:97: checkHoldCursors(int,boolean) in org.apache.derby.jdbc.EmbedPooledConnection cannot be applied to (int) [javac] super.checkHoldCursors(holdability); [javac] ^
        Hide
        Anurag Shekhar added a comment -

        Added classes
        EmbedXAConnection40 and EmbedPoolableConnection40
        EmbedPoolableconnection40 extends from EmbedConnection. It has stub implementation of the jdbc4.0 methods of PoolableConnection.
        EmbedXAConnection40 extends from EmbedPoolableConnection40. All the methods in EmbedXAConnection is copied to this class too.

        Modifed Class
        XAStatementControl
        Changed this to use EmbedPoolableConnection so that EmbedXAConnection40 can be passed this.

        Right now the EmbedXAConnection40 EmbedPoolableConnection40 are unused (there is no class which uses these) and there there is no way
        to get these from user application.
        4.0 DataSource implementation which will be provided as part of jira 1137 will be used to instantiate these classes.

        Show
        Anurag Shekhar added a comment - Added classes EmbedXAConnection40 and EmbedPoolableConnection40 EmbedPoolableconnection40 extends from EmbedConnection. It has stub implementation of the jdbc4.0 methods of PoolableConnection. EmbedXAConnection40 extends from EmbedPoolableConnection40. All the methods in EmbedXAConnection is copied to this class too. Modifed Class XAStatementControl Changed this to use EmbedPoolableConnection so that EmbedXAConnection40 can be passed this. Right now the EmbedXAConnection40 EmbedPoolableConnection40 are unused (there is no class which uses these) and there there is no way to get these from user application. 4.0 DataSource implementation which will be provided as part of jira 1137 will be used to instantiate these classes.

          People

          • Assignee:
            Anurag Shekhar
            Reporter:
            Anurag Shekhar
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development