Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.1-incubating
    • Component/s: None
    • Labels:
      None

      Activity

      Show
      Christian Kaltepoth added a comment - Done! https://cwiki.apache.org/confluence/display/DeltaSpike/Tools
      Hide
      Gerhard Petracek added a comment -
      Show
      Gerhard Petracek added a comment - thx christian! please attach it to https://cwiki.apache.org/confluence/display/DeltaSpike/Tools
      Hide
      Christian Kaltepoth added a comment -

      I'm sorry. I did mistake regarding the indentation for wrapped lines. Here is the correct formatter profile.

      Show
      Christian Kaltepoth added a comment - I'm sorry. I did mistake regarding the indentation for wrapped lines. Here is the correct formatter profile.
      Hide
      Christian Kaltepoth added a comment -

      I've created an Eclipse Code Formatter profile based on these conventions. I think this is very interesting for people using Eclipse who want to start some hacking.

      Perhaps we could add this profile and the one for IntelliJ to the git repository?

      Show
      Christian Kaltepoth added a comment - I've created an Eclipse Code Formatter profile based on these conventions. I think this is very interesting for people using Eclipse who want to start some hacking. Perhaps we could add this profile and the one for IntelliJ to the git repository?
      Hide
      Gerhard Petracek added a comment -

      the next step is to add checkstyle rules for #1-#9

      Show
      Gerhard Petracek added a comment - the next step is to add checkstyle rules for #1-#9
      Hide
      Gerhard Petracek added a comment -

      the vote for #1-#9 passed

      Show
      Gerhard Petracek added a comment - the vote for #1-#9 passed
      Hide
      Marius Bogoevici added a comment -

      11) order of import specified, e.g.:

      import statics;
      
      import java....;
      
      import javax......;
      
      import others;
      
      import org.deltaspike;
      

      This helps further reducing irrelevant differences on change and is enforceable by Checkstyle (see http://checkstyle.sourceforge.net/config_imports.html).

      Show
      Marius Bogoevici added a comment - 11) order of import specified, e.g.: import statics; import java....; import javax......; import others; import org.deltaspike; This helps further reducing irrelevant differences on change and is enforceable by Checkstyle (see http://checkstyle.sourceforge.net/config_imports.html ).
      Hide
      Gerhard Petracek added a comment -

      we can add further rules later on.

      e.g.
      10) unused imports aren't allowed

      Show
      Gerhard Petracek added a comment - we can add further rules later on. e.g. 10) unused imports aren't allowed
      Hide
      Gerhard Petracek added a comment - - edited

      conventions used in myfaces codi:

      1) no tabs, only spaces (4 spaces).
      2) bracelets on new line
      3) force bracelets
      4) 4 spaces indent size
      5) a space between keyword and round bracket
      6) a space before and after an operand
      7) line width: 120
      8) no underscore at the beginning
      9) no wildcard imports

      Show
      Gerhard Petracek added a comment - - edited conventions used in myfaces codi: 1) no tabs, only spaces (4 spaces). 2) bracelets on new line 3) force bracelets 4) 4 spaces indent size 5) a space between keyword and round bracket 6) a space before and after an operand 7) line width: 120 8) no underscore at the beginning 9) no wildcard imports

        People

        • Assignee:
          Mark Struberg
          Reporter:
          Gerhard Petracek
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development