Uploaded image for project: 'DeltaSpike'
  1. DeltaSpike
  2. DELTASPIKE-124

tests in ContainerCtrlTckTest don't stop contexts at the end

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Not A Problem
    • Affects Version/s: None
    • Fix Version/s: 0.2-incubating
    • Component/s: Tests
    • Labels:
      None

      Description

      no test in ContainerCtrlTckTest calls:
      CdiContainer#getContextControl#stopContexts
      before
      CdiContainer#shutdown
      imo the current approach is too error prone - see DELTASPIKE-123

      1. DELTASPIKE-124.patch
        7 kB
        Gerhard Petracek

        Activity

        Hide
        struberg Mark Struberg added a comment -

        shipped in deltaspike-0.2-incubating

        Show
        struberg Mark Struberg added a comment - shipped in deltaspike-0.2-incubating
        Hide
        gpetracek Gerhard Petracek added a comment -

        needs to be documented

        Show
        gpetracek Gerhard Petracek added a comment - needs to be documented
        Hide
        struberg Mark Struberg added a comment -

        that's perfectly fine. CdiContainer#shutdown() of any CdiContainer should stop all still open contexts anyway!
        This is true for built-in Contexts and should also be the case for custom contexts. They can (and should) observe the BeforeShutdown event to gracefully cleanup any contextual instances left in their context stores.

        Show
        struberg Mark Struberg added a comment - that's perfectly fine. CdiContainer#shutdown() of any CdiContainer should stop all still open contexts anyway! This is true for built-in Contexts and should also be the case for custom contexts. They can (and should) observe the BeforeShutdown event to gracefully cleanup any contextual instances left in their context stores.

          People

          • Assignee:
            struberg Mark Struberg
            Reporter:
            gpetracek Gerhard Petracek
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development