[DDLUTILS-73] SQL syntax bug in PostgreSQL 8.1 for ALTER COLUMN

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0 RC1
• Component/s: Core - PostgreSql
• Environment: PostgreSQL 8.1
• Assignee: Thomas Dudziak
• Reporter: Vignesh Swaminathan
• Created: 21/Feb/06 14:46
• Updated: 04/Jun/07 02:34
• Resolved: 13/Jul/06 13:32

Description

The following code has to be added to PostgreSQLBuilder class to make it work for altering columns in PostgreSQL

/**

• Generates the alter statement to add or modify a single column on a table.
  *
• @param table The table the index is on
• @param column The column to drop
• @param isNewColumn Whether the column should be added
  */
  public void writeColumnAlterStmt(Table table, Column column, boolean isNewColumn) throws IOException { writeTableAlterStmt(table); print(isNewColumn ? "ADD " : "ALTER "); if(isNewColumn) writeColumn(table, column); else writeAlterColumn(table, column); printEndOfStatement(); }

/**

• Outputs the DDL for the specified column.
• @param table The table containing the column
• @param column The column
  */
  protected void writeAlterColumn(Table table, Column column) throws IOException
  {
  //see comments in columnsDiffer about null/"" defaults
  printIdentifier(getColumnName(column));
  print(" TYPE ");
  print(getSqlType(column));

if ((column.getDefaultValue() != null) ||
(getPlatformInfo().isIdentitySpecUsesDefaultValue() && column.isAutoIncrement()))
{
if (!getPlatformInfo().isSupportingDefaultValuesForLongTypes() &&
((column.getTypeCode() == Types.LONGVARBINARY) || (column.getTypeCode() == Types.LONGVARCHAR)))

{ throw new DynaSqlException("The platform does not support default values for LONGVARCHAR or LONGVARBINARY columns"); }

print(" DEFAULT ");
writeColumnDefaultValue(table, column);
}
if (column.isRequired())

{ print(" "); writeColumnNotNullableStmt(); }

else if (getPlatformInfo().isRequiringNullAsDefaultValue() &&
getPlatformInfo().hasNullDefault(column.getTypeCode()))

{ print(" "); writeColumnNullableStmt(); }

if (column.isAutoIncrement() && !getPlatformInfo().isIdentitySpecUsesDefaultValue())
{
if (!getPlatformInfo().isSupportingNonPKIdentityColumns() && !column.isPrimaryKey())

{ throw new DynaSqlException("Column "+column.getName()+" in table "+table.getName()+" is auto-incrementing but not a primary key column, which is not supported by the platform"); }

print(" ");
writeColumnAutoIncrementStmt(table, column);
}
}