Commons DbUtils
  1. Commons DbUtils
  2. DBUTILS-98

Add missing JavaDoc to QueryRunner#insert

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6
    • Labels:
      None

      Activity

      Hide
      Moandji Ezana added a comment -

      QueryRunner_insert_add_javadoc.patch adds the missing documentation.

      Show
      Moandji Ezana added a comment - QueryRunner_insert_add_javadoc.patch adds the missing documentation.
      Hide
      Simone Tripodi added a comment -

      Thanks a lot Moandji for the patch, I applied it, see r1374960.

      I had to do some work to apply it, because - and please take note about that for future patches:

      • the provided patch contains code modifications that had already been applied, so do an svn up on your local copy, before creating patches;
      • the Javadoc comments were few times inconsistent (@param order, last comment should have been a copy'n'paste refuse)

      Thanks!

      Show
      Simone Tripodi added a comment - Thanks a lot Moandji for the patch, I applied it, see r1374960. I had to do some work to apply it, because - and please take note about that for future patches: the provided patch contains code modifications that had already been applied, so do an svn up on your local copy, before creating patches; the Javadoc comments were few times inconsistent ( @param order, last comment should have been a copy'n'paste refuse) Thanks!
      Hide
      Moandji Ezana added a comment -

      Hi Simone,

      Sorry about the rookie mistakes. I'll blame #1 on late night inattention. I have no excuse for #2 .

      Show
      Moandji Ezana added a comment - Hi Simone, Sorry about the rookie mistakes. I'll blame #1 on late night inattention. I have no excuse for #2 .
      Hide
      Simone Tripodi added a comment -

      Don't worry, as you can notice it wasn't a huge issue
      Just take care of a checklist before, everything's fine
      Thanks for contributing!

      Show
      Simone Tripodi added a comment - Don't worry, as you can notice it wasn't a huge issue Just take care of a checklist before, everything's fine Thanks for contributing!

        People

        • Assignee:
          Simone Tripodi
          Reporter:
          Moandji Ezana
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development