[DBUTILS-109] AbstractExecutor.currentPosition should be an int

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0
• Assignee: Unassigned
• Reporter: Sebb
• Created: 17/Mar/13 21:00
• Updated: 13/May/13 20:47
• Resolved: 13/May/13 20:47

Description

AbstractExecutor.currentPosition is currently an Integer.

It is only used here:

posList.add(++currentPosition);

This involves converting the Integer to an int, incrementing the int and then converting back to an Integer.

It would be rather more efficient to create the field as an int.

Alternatively, if the class is supposed to be thread-safe, maybe an AtomicInteger would be better.

Integer is not the best choice here.