[DBCP-81] [dbcp] NPE in PoolableConnectionFactory validating the connection with an invalid SQL statement

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.2

Environment

Operating System: All
Platform: All

• Bugzilla Id: 36685
• Assignee: Unassigned
• Reporter: Joerg Schaible
• Created: 16/Sep/05 23:03
• Updated: 25/Mar/08 08:11
• Resolved: 25/Mar/08 08:11

Description

The PooleableConnectionFactory.validateConnection(Connection) throws a NPE, if
the provided SQL statement for validation is invalid itself (e.g. uses a
non-existing table). See the code snippet below. If stmt.executeQuery(query)
throws an SQLException, rset is still null, but will be closed in the finally
block ==> NPE!

if(null != query) {
Statement stmt = null;
ResultSet rset = null;
try {
stmt = conn.createStatement();
rset = stmt.executeQuery(query);
if(!rset.next())

{ throw new SQLException("validationQuery didn't return a row"); }

} finally {
try

{ rset.close(); }

catch(Exception t)

{ // ignored }
try { stmt.close(); } catch(Exception t) { // ignored }

}
}