[DBCP-573] DataSource implementations do not implement Wrapper interface correctly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.8.0
• Fix Version/s: 2.9.0
• Assignee: Unassigned
• Reporter: Réda Housni Alaoui
• Created: 01/Apr/21 07:00
• Updated: 01/Jun/21 09:22
• Resolved: 31/May/21 15:11

Description

Let's take BasicDataSource as an example. Its code is currently:

@Override
public boolean isWrapperFor(final Class<?> iface) throws SQLException {
    return false;
}

@Override
public <T> T unwrap(final Class<T> iface) throws SQLException {
    throw new SQLException("BasicDataSource is not a wrapper.");
}

This breaks consumers relying on Wrapper being correctly implemented.

The DataSource should at least check if this is an instance of iface and return it from unwrap if it is.

Issue Links

• links to: Pull request