[DBCP-564] BasicManagedDataSource leaks connections opened after transaction is rollback-only

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.7.0
• Fix Version/s: 2.8.0
• Flags: Patch
• Assignee: Unassigned
• Reporter: Florent Guillaume
• Created: 13/May/20 17:59
• Updated: 14/May/20 16:27
• Resolved: 14/May/20 14:29

Description

In the following situation a connection will be leaked and never returned to the pool:

• a BasicManagedDataSource is instantiated for a non-XA driver class name (but with a TransactionManager and a TransactionSynchronizationRegistry),
• a transaction is started then switched to rollback-only,
• a connection is acquired from the datasource,
• the connection is closed,
• the transaction is rolled back.

The leak happens because, even though there is code in TransactionContext.addTransactionContextListener to properly use the transactionSynchronizationRegistry to register the suitable Synchronization to do cleanup in afterCompletion, the transactionSynchronizationRegistry is actually null because of the way the LocalXAConnectionFactory was created in BasicManagedDataSource.createConnectionFactory.

PR: https://github.com/apache/commons-dbcp/pull/39