[DBCP-540] Close ObjectOutputStream before calling toByteArray on underlying ByteArrayOutputStream #28

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 2.7.0
• External issue URL: https://github.com/apache/commons-dbcp/pull/28
• External issue ID: 28
• Assignee: Unassigned
• Reporter: Gary D. Gregory
• Created: 30/Mar/19 01:18
• Updated: 30/Mar/19 01:23
• Resolved: 30/Mar/19 01:23

Description

Close ObjectOutputStream before calling toByteArray on underlying ByteArrayOutputStream #28.

https://github.com/apache/commons-dbcp/pull/28:

When an ObjectOutputStream instance wraps an underlying ByteArrayOutputStream instance,
it is recommended to flush or close the ObjectOutputStream before invoking the underlying instances's toByteArray(). Although in this case it is not strictly necessary because writeObject method is invoked right before toByteArray, and writeObject internally calls flush/drain. However, it is good practice to call flush/close explicitly as mentioned, for example, here.
This pull request flips the order of close and toytBeArray methods.