Details
-
Improvement
-
Status: Resolved
-
Minor
-
Resolution: Fixed
-
2.1.1
-
None
-
Patch
Description
In PoolingConnection, the following methods are not defined.
-prepareStatement(String sql, int[] columnIndexes)
-prepareStatement(String sql, int resultSetType, int resultSetConcurrency, int resultSetHoldability)
-prepareStatement(String sql, String[] columnNames)
-prepareCall(String sql, int resultSetType, int resultSetConcurrency, int resultSetHoldability)
Therefore, when calling these methods, we can not cache statements.
I had tried to implement these methods in PoolingConnection.
However, because the code in the PoolingConnection#makeObject is a little complex,
I thought that it is difficult to add new conditions.
So, in order to more easily implement the Connection#prepareStatement that are not defined in the PoolingConnection,
I did a refactoring for the PStmtKey and PoolingConnection.
If these refactoring are accepted,I have a plan to implement the following methods to PoolingConnection
in order to cache all of Prepared or Callable Statement.
-prepareStatement(String sql, int[] columnIndexes)
-prepareStatement(String sql, int resultSetType, int resultSetConcurrency, int resultSetHoldability)
-prepareStatement(String sql, String[] columnNames)
-prepareCall(String sql, int resultSetType, int resultSetConcurrency, int resultSetHoldability)