[DBCP-420] InstanceKeyDataSource discards native SQLException when given password does not match password used to create the connection

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0
• Fix Version/s: 2.1
• Assignee: Unassigned
• Reporter: Bjorn Vidar Remme
• Created: 22/May/14 12:08
• Updated: 24/Feb/15 03:23
• Resolved: 23/May/14 15:10

Description

The throw in InstanceKeyDataSource at line 936 does not pass on the native SQL exception from the connection test:

} catch (SQLException ex) {
                // Password has not changed, so refuse client, but return connection to the pool
                closeDueToException(info);
                throw new SQLException("Given password did not match password used"
                                       + " to create the PooledConnection.");
            }

It would be great if this throw could include the cause exception:

                throw new SQLException("Given password did not match password used"
                                       + " to create the PooledConnection.", ex);

as we have code that detects login related SQLExceptions and takes actions on them.