[DBCP-351] setAutoCommit called too many times

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4
• Fix Version/s: 2.0
• Assignee: Unassigned
• Reporter: OD
• Created: 01/Feb/11 12:47
• Updated: 31/May/14 04:11
• Resolved: 14/Feb/14 11:47

Description

passivateObject in PoolableConnectionFactory sets autoCommit to true, even if defaultAutoCommit is set to false. This results in two extra db queries for every use of the connection (set false, do work, set true). This creates a significant amount of overhead, even if the connection is never even used.

I propose it be changed to:

if(conn.getAutoCommit() != _defaultAutoCommit)
{
conn.setAutoCommit(_defaultAutoCommit);
}