Commons Dbcp
  1. Commons Dbcp
  2. DBCP-341

LocalXAConnectionFactory does not properly check if Xid is equal to currentXid when resuming

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: 1.5.1, 2.0
    • Labels:
      None

      Description

      The current implementation checks if Xid is not equal to currentXid using the != . That doesn't work in all cases resulting in XAException.
      I think that this check should be left to the Xid implementation.

      1. DBPC-341-patch.txt
        0.9 kB
        Ioannis Canellos

        Activity

        Ioannis Canellos created issue -
        Hide
        Ioannis Canellos added a comment -

        I am attaching a patch that replaces the != operation with a call the Xid equals method.

        Show
        Ioannis Canellos added a comment - I am attaching a patch that replaces the != operation with a call the Xid equals method.
        Ioannis Canellos made changes -
        Field Original Value New Value
        Attachment DBPC-341-patch.txt [ 12453688 ]
        Phil Steitz made changes -
        Fix Version/s 1.3.1 [ 12314492 ]
        Fix Version/s 1.4.1 [ 12314493 ]
        Hide
        ggregory@seagullsw.com added a comment -

        typo

        Show
        ggregory@seagullsw.com added a comment - typo
        ggregory@seagullsw.com made changes -
        Summary LocalXAConnectionFactory does not properly checks if Xid is equal to currentXid when resuming LocalXAConnectionFactory does not properly check if Xid is equal to currentXid when resuming
        Hide
        Mark Thomas added a comment -

        Thanks for the report and the fix. Sorry it has taken so long to address this.

        I've fixed trunk for the 2.x series the 1.5.x branch. It will be included in the next release of each.

        If there are further 1.3.x and 1.4.x releases (currently being discussed on the dev mailing list) my expectation is that they will be generated from the 1.5.x branch so will pick up this fix too.

        Show
        Mark Thomas added a comment - Thanks for the report and the fix. Sorry it has taken so long to address this. I've fixed trunk for the 2.x series the 1.5.x branch. It will be included in the next release of each. If there are further 1.3.x and 1.4.x releases (currently being discussed on the dev mailing list) my expectation is that they will be generated from the 1.5.x branch so will pick up this fix too.
        Mark Thomas made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.5.1 [ 12325670 ]
        Fix Version/s 2.0 [ 12313721 ]
        Fix Version/s 1.3.1 [ 12314492 ]
        Fix Version/s 1.4.1 [ 12314493 ]
        Resolution Fixed [ 1 ]
        Phil Steitz made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        1249d 5h 17m 1 Mark Thomas 02/Feb/14 20:46
        Resolved Resolved Closed Closed
        386d 6h 36m 1 Phil Steitz 24/Feb/15 03:23

          People

          • Assignee:
            Unassigned
            Reporter:
            Ioannis Canellos
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development