Commons Dbcp
  1. Commons Dbcp
  2. DBCP-341

LocalXAConnectionFactory does not properly check if Xid is equal to currentXid when resuming

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: 1.5.1, 2.0
    • Labels:
      None

      Description

      The current implementation checks if Xid is not equal to currentXid using the != . That doesn't work in all cases resulting in XAException.
      I think that this check should be left to the Xid implementation.

      1. DBPC-341-patch.txt
        0.9 kB
        Ioannis Canellos

        Activity

        Mark Thomas made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.5.1 [ 12325670 ]
        Fix Version/s 2.0 [ 12313721 ]
        Fix Version/s 1.3.1 [ 12314492 ]
        Fix Version/s 1.4.1 [ 12314493 ]
        Resolution Fixed [ 1 ]
        Hide
        Mark Thomas added a comment -

        Thanks for the report and the fix. Sorry it has taken so long to address this.

        I've fixed trunk for the 2.x series the 1.5.x branch. It will be included in the next release of each.

        If there are further 1.3.x and 1.4.x releases (currently being discussed on the dev mailing list) my expectation is that they will be generated from the 1.5.x branch so will pick up this fix too.

        Show
        Mark Thomas added a comment - Thanks for the report and the fix. Sorry it has taken so long to address this. I've fixed trunk for the 2.x series the 1.5.x branch. It will be included in the next release of each. If there are further 1.3.x and 1.4.x releases (currently being discussed on the dev mailing list) my expectation is that they will be generated from the 1.5.x branch so will pick up this fix too.
        Mark Thomas committed 1563710 (2 files)
        Reviews: none

        Fix DBCP-341
        LocalXAConnectionFactory does not properly check if Xid is equal to currentXid when resuming which may result in an XAException.
        Patch by Ioannis Canellos

        Mark Thomas committed 1563709 (2 files)
        Reviews: none

        Fix DBCP-341
        LocalXAConnectionFactory does not properly check if Xid is equal to currentXid when resuming which may result in an XAException.
        Patch by Ioannis Canellos

        ggregory@seagullsw.com made changes -
        Summary LocalXAConnectionFactory does not properly checks if Xid is equal to currentXid when resuming LocalXAConnectionFactory does not properly check if Xid is equal to currentXid when resuming
        Hide
        ggregory@seagullsw.com added a comment -

        typo

        Show
        ggregory@seagullsw.com added a comment - typo
        Phil Steitz made changes -
        Fix Version/s 1.3.1 [ 12314492 ]
        Fix Version/s 1.4.1 [ 12314493 ]
        Ioannis Canellos made changes -
        Field Original Value New Value
        Attachment DBPC-341-patch.txt [ 12453688 ]
        Hide
        Ioannis Canellos added a comment -

        I am attaching a patch that replaces the != operation with a call the Xid equals method.

        Show
        Ioannis Canellos added a comment - I am attaching a patch that replaces the != operation with a call the Xid equals method.
        Ioannis Canellos created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Ioannis Canellos
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development