[DBCP-339] orphaned connectionPools created on Exception within createDataSource method

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 1.2.2, 1.3, 1.4
• Fix Version/s: 1.3.1, 1.4.1

Environment

Linux
MySQL 5.1.47
JDK 1.6
commonsPool 1.5.4

• Assignee: Unassigned
• Reporter: Mike Bartlett
• Created: 08/Jul/10 16:42
• Updated: 25/Apr/11 16:27
• Resolved: 24/Apr/11 00:26

Description

When an Exception is thrown in the BasicDataSource.createDataSource after the connectionPool instance variable has been set the connectionPool is not closed.

If the timeBetweenEvictionRunsMillis is greater than zero a TaskTimer evictor is created in the GenericObjectPool. This TaskTimer keeps running even though the DataSource was not successfully created. The evictor when it runs will attempt to create connections for this orphaned connectionPool up to the min connections (minIdle).

If the database is down when the createDataSource is called an Exception will be thrown and an orphaned connectionPool will be created. If serveral retries are attempted while the database is down several orphaned connectionPools are created. Once the database is back up, all these orphaned connectionPool's evitor threads will attempt to created minIdle connections to the database. This exhausts the max num connections on the database.

One solution to to close the connectionPool when an Exception is thrown within the createDataSource method.

Issue Links

• duplicates: DBCP-342 Not cleaned up commons pool's evictor task when SQLException occurs after the GenericObjectPool is initialized in createDataSource.