[DBCP-318] PerUserPoolDataSource.getPooledConnectionAndInfo multi-threading bug

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Assignee: Unassigned
• Reporter: Sebb
• Created: 05/Jan/10 20:01
• Updated: 15/Feb/10 01:43
• Resolved: 05/Jan/10 20:07

Description

PerUserPoolDataSource.getPooledConnectionAndInfo(user,pass) has the code:

Object pool = pools.get(key); // (1) pools = instance variable
synchronized(this) {
    if (pool == null) {
        try {
            registerPool(username, password);
            pool = pools.get(key);
[...]

The first get() call can return null to multiple threads, so multiple threads can register the pool.
This allows more than maxActive() connections to be returned.