Commons Dbcp
  1. Commons Dbcp
  2. DBCP-317

Findbugs: Class doesn't override equals in superclass

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: 2.0
    • Labels:
      None

      Description

      Findbugs: Class doesn't override equals in superclass - 8 instances

      "This class extends a class that defines an equals method and adds fields, but doesn't define an equals method itself. Thus, equality on instances of this class will ignore the identity of the subclass and the added fields. Be sure this is what is intended, and that you don't need to override the equals method. Even if you don't need to override the equals method, consider overriding it anyway to document the fact that the equals method for the subclass just return the result of invoking super.equals(o). "

      Classes (superclass) are:

      cpdsadapter.ConnectionImpl doesn't override DelegatingConnection.equals
      datasources.LRUMap doesn't override SequencedHashMap.equals
      managed.ManagedConnection doesn't override DelegatingConnection.equals
      managed.PoolableManagedConnection doesn't override DelegatingConnection.equals
      PoolableCallableStatement doesn't override DelegatingCallableStatement.equals
      PoolableConnection doesn't override DelegatingConnection.equals
      PoolablePreparedStatement doesn't override DelegatingPreparedStatement.equals
      PoolingConnection doesn't override DelegatingConnection.equals

        Issue Links

          Activity

          No work has yet been logged on this issue.

            People

            • Assignee:
              Unassigned
              Reporter:
              Sebb
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development