[DBCP-313] PooledConnection.removeConnectionEventListener(ConnectionEventListener) does not throw any Exceptions, yet DBCP protects calls to it

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Assignee: Unassigned
• Reporter: Sebb
• Created: 05/Jan/10 00:54
• Updated: 15/Feb/10 01:46
• Resolved: 05/Jan/10 03:05

Description

javax.sql.PooledConnection.removeConnectionEventListener(ConnectionEventListener) does not throw any Exceptions, yet DBCP protects calls to it, generally ignoring any Exception.

For example, in datasources.CPDSConnectionFactory:

public void destroyObject(Object obj) throws Exception {
    if (obj instanceof PooledConnectionAndInfo) {
        PooledConnection pc = ((PooledConnectionAndInfo)obj).getPooledConnection();
        try {
            pc.removeConnectionEventListener(this);
        } catch (Exception e) {
            //ignore
        }
....

This seems wrong, as the code may accidentally swallow a genuine Exception.