Uploaded image for project: 'Commons DBCP'
  1. Commons DBCP
  2. DBCP-289

Allow client to set a XADatasource instance instead of only its classname in BasicManagedDataSource

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.2.2
    • 1.3
    • None

    Description

      BasicManagedDataSource currently allows to set the classname of an XADatasource to create XA-enabled connections.
      If done so the datasource is created using the Reflection-API.

      I think in most cases this is not enough, since DataSources usually need some kind of configuration. In my case this would be the connection-url to the database (I use MysqlXADatasource which wants its setUrl(url) method called).

      For this reason i think it would be useful to let the client set the XADataSource instance instead of its classname (optional). The same is done now with the TransactionManager-Implementation.

      For this reason i'd suggest a getter and setter as well as a new member xaDataSourceInstance as an alternative option to the classname.

      Attachments

        1. set_xadatasource_instance.patch
          4 kB
          Marc Kannegießer

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. DBCP-360 BasicManagedDataSource fails with OracleXADataSource

          • Major - Major loss of function.
          • Closed

          Activity

            People

              Unassigned Unassigned
              kannegiesser Marc Kannegießer
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: