Commons Dbcp
  1. Commons Dbcp
  2. DBCP-241

NPE in case of an SQLException to be thrown on checkOpen() in DelegatingConnection

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.2
    • Fix Version/s: 1.3
    • Labels:
      None

      Description

      I only got it from the Spring forums (http://forum.springframework.org/showthread.php?t=44068). I have no idea which version or if it is already fixed. It should be easy to review.

      Stacktrace:

      java.lang.NullPointerException
      at org.apache.commons.dbcp.PoolingConnection.toString(PoolingConnection.java:248)
      at java.lang.String.valueOf(String.java:2615)
      at java.lang.StringBuffer.append(StringBuffer.java:220)
      at org.apache.commons.dbcp.DelegatingConnection.checkOpen(DelegatingConnection.java:354)
      at org.apache.commons.dbcp.DelegatingConnection.prepareStatement(DelegatingConnection.java:246)
      at org.apache.commons.dbcp.PoolingDataSource$PoolGuardConnectionWrapper.prepareStatement(PoolingDataSource.java:302)
      at org.hibernate.jdbc.AbstractBatcher.getPreparedStatement(AbstractBatcher.java:505)
      at org.hibernate.jdbc.AbstractBatcher.getPreparedStatement(AbstractBatcher.java:423)
      at org.hibernate.jdbc.AbstractBatcher.prepareQueryStatement(AbstractBatcher.java:139)

      implementation of the method:

      protected void checkOpen() throws SQLException {
      if(_closed)

      { throw new SQLException ("Connection " + _conn + " is closed."); }

      }

      Regards

      Joerg

        Activity

        Jörg Heinicke created issue -
        Jörg Heinicke made changes -
        Field Original Value New Value
        Description I only got it from the Spring forums (http://forum.springframework.org/showthread.php?t=44068), no idea which version or if it is already fixed. It should be easy to review.

        Stacktrace:

        java.lang.NullPointerException
        at org.apache.commons.dbcp.PoolingConnection.toString(PoolingConnection.java:248)
        at java.lang.String.valueOf(String.java:2615)
        at java.lang.StringBuffer.append(StringBuffer.java:220)
        at org.apache.commons.dbcp.DelegatingConnection.checkOpen(DelegatingConnection.java:354)
        at org.apache.commons.dbcp.DelegatingConnection.prepareStatement(DelegatingConnection.java:246)
        at org.apache.commons.dbcp.PoolingDataSource$PoolGuardConnectionWrapper.prepareStatement(PoolingDataSource.java:302)
        at org.hibernate.jdbc.AbstractBatcher.getPreparedStatement(AbstractBatcher.java:505)
        at org.hibernate.jdbc.AbstractBatcher.getPreparedStatement(AbstractBatcher.java:423)
        at org.hibernate.jdbc.AbstractBatcher.prepareQueryStatement(AbstractBatcher.java:139)

        implementation of the method:

            protected void checkOpen() throws SQLException {
                if(_closed) {
                    throw new SQLException
                        ("Connection " + _conn + " is closed.");
                }
            }

        Regards

        Joerg
        I only got it from the Spring forums (http://forum.springframework.org/showthread.php?t=44068). I have no idea which version or if it is already fixed. It should be easy to review.

        Stacktrace:

        java.lang.NullPointerException
        at org.apache.commons.dbcp.PoolingConnection.toString(PoolingConnection.java:248)
        at java.lang.String.valueOf(String.java:2615)
        at java.lang.StringBuffer.append(StringBuffer.java:220)
        at org.apache.commons.dbcp.DelegatingConnection.checkOpen(DelegatingConnection.java:354)
        at org.apache.commons.dbcp.DelegatingConnection.prepareStatement(DelegatingConnection.java:246)
        at org.apache.commons.dbcp.PoolingDataSource$PoolGuardConnectionWrapper.prepareStatement(PoolingDataSource.java:302)
        at org.hibernate.jdbc.AbstractBatcher.getPreparedStatement(AbstractBatcher.java:505)
        at org.hibernate.jdbc.AbstractBatcher.getPreparedStatement(AbstractBatcher.java:423)
        at org.hibernate.jdbc.AbstractBatcher.prepareQueryStatement(AbstractBatcher.java:139)

        implementation of the method:

            protected void checkOpen() throws SQLException {
                if(_closed) {
                    throw new SQLException
                        ("Connection " + _conn + " is closed.");
                }
            }

        Regards

        Joerg
        Summary NPE in case of an SQLException on checkOpen() in DelegatingConnection NPE in case of an SQLException to be thrown on checkOpen() in DelegatingConnection
        Phil Steitz made changes -
        Affects Version/s 1.2.2 [ 12311976 ]
        Fix Version/s 1.3 [ 12311977 ]
        Phil Steitz made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Henri Yandell made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Jörg Heinicke
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development