Commons Dbcp
  1. Commons Dbcp
  2. DBCP-229

Track callers of active connections for debugging

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0
    • Labels:
      None

      Description

      Lately we got the following exception
      org.apache.commons.dbcp.SQLNestedException: Cannot get a connection, pool exhausted
      at
      org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:103)
      at
      org.apache.commons.dbcp.BasicDataSource.getConnection(BasicDataSource.java:540)

      The reason for that was that some piece of code opened a connection, but never closed it. Tracking the active connections (and the callers of the getConnection method) would it make it easier to find such erroneous code.
      One possible approach would be to add the connection returned by BasicDataSource.getConnection together with the stacktrace in a Map holding all active connections. And removing the connection from the map during PoolableDataSource.close().

        Activity

        Armin Häberling created issue -
        Phil Steitz made changes -
        Field Original Value New Value
        Fix Version/s 1.4 [ 12312615 ]
        Phil Steitz made changes -
        Fix Version/s 2.0 [ 12313721 ]
        Fix Version/s 1.4 [ 12312615 ]
        Mark Thomas made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Phil Steitz made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Armin Häberling
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development