[DAYTRADER-51] NPE when logging in with an unknown username

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0
• Fix Version/s: 2.1.7, 2.2.1, 3.0-M2, 3.0
• Component/s: Web Tier
• Assignee: Ming Xia
• Reporter: Jarek Gawor
• Created: 08/Aug/07 18:55
• Updated: 24/Nov/10 15:38
• Resolved: 24/Nov/10 15:37

Description

I was testing DayTrayder (in web services mode) and tried to log in with a bad username. That resulted in a bad NPE exception because org.apache.geronimo.samples.daytrader.direct.TradeDirect.login() returned null instead of throwing an exception. I assume an exception should be raised. If null can be returned the web services code needs to be changed to handle that.

Here's what I see in the logs:

14:29:43,775 ERROR [Log] Error: TradeDirect:login – failure to find account forhhh
14:29:43,776 ERROR [Log] Error: TradeDirect:login – error logging in user
javax.ejb.FinderException: Cannot find account forhhh
javax.ejb.FinderException: Cannot find account forhhh
at org.apache.geronimo.samples.daytrader.direct.TradeDirect.login(TradeDirect.java:1487)
at org.apache.geronimo.samples.daytrader.TradeAction.login(TradeAction.java:455)
at org.apache.geronimo.samples.daytrader.soap.TradeWSAction.login(TradeWSAction.java:177)

.....

Caused by: java.lang.NullPointerException
at org.apache.geronimo.samples.daytrader.soap.Convert.convertAccountDataBean(Convert.java:97)
at org.apache.geronimo.samples.daytrader.soap.TradeWSAction.login(TradeWSAction.java:177)
... 41 more