Uploaded image for project: 'Daffodil'
  1. Daffodil
  2. DAFFODIL-2432

Need validation of tunable values

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 3.1.0
    • API
    • None

    Description

      The TunableGenerator.scala file use the dafext.xsd file to generate code to parse tunables. This handles things like correctly converting types or handling default values. Unfortunately, it only does type validation, nothing about value validation (e.g. value must be positive). This means we must either add custom validation code for tunable values long after they have been set, which can possibly lead to confusion, or we don't do any validation at all, which can lead to undefined behavior.

      Instead, we should add xs:restriction's to the tunables list in dafext.xsd, and have the TunableGenerator create code to validate based on these restrictions. We don't necessarily need to support all XSD restrictions--probably min/maxInclusive is suffiicient.

      Attachments

        Activity

          People

            slawrence Steve Lawrence
            slawrence Steve Lawrence
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: