[DAFFODIL-2300] SonarCloud action is triggered on forks and fails

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.6.0
• Component/s: Infrastructure
• Assignee: Steve Lawrence
• Reporter: Steve Lawrence
• Created: 23/Mar/20 13:55
• Updated: 13/Apr/20 14:30
• Resolved: 24/Mar/20 21:46

Description

Whenever we push a branch to a fork, the sonarcloud github action is tiggered on that fork. Since most people probably don't have a personal sonarcloud account associated with their fork this is going to fail and sends an email. This can be annoying and potentially confusing for new contributors.

We should modify this action so that it is only triggered conditionally. Maybe we detect when the repo is not the main apache repo, or perhaps skip it if the SONAR_TOKEN environment variable is not set. Maybe there's some other alternative.