Uploaded image for project: 'Daffodil'
  1. Daffodil
  2. DAFFODIL-2256

Purge scala.math.{BigInt, BigDecimal} from code

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.5.0
    • 2.5.0
    • Clean Ups
    • None

    Description

      We have switched to using only Java's implementation of BigInteger and BigDecimal. However, we still have some lingering usages of Scala's version.

      We can find such uses by using the dissasembler:

      javap -c -l `find . -name *.class | grep scala-2.12` > src.bytecode

      Then searching the resulting file for "scala/math/BigInt" and "scala/math/BigDecimal"

      Since all our tests pass, these appear to not cause any functional issue, but should be cleaned up for purposes of consistency.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            brandon.sloane Brandon Sloane
            brandon.sloane Brandon Sloane
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment