[DAFFODIL-1954] Java version greater than 1.8 cause failure

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.3.0
• Component/s: Back End
• Labels: beginner
• Assignee: Steve Lawrence
• Reporter: Steve Lawrence
• Created: 13/Jun/18 19:48
• Updated: 20/May/21 12:34
• Resolved: 17/Dec/18 14:23

Description

If you try to use Daffodil with Java 10, you get a failure with the exception:

java.lang.NumberFormatException: Not a version: 10
	at scala.util.PropertiesTrait$class.parts$1(Properties.scala:184)
	at scala.util.PropertiesTrait$class.isJavaAtLeast(Properties.scala:188)
	at scala.util.Properties$.isJavaAtLeast(Properties.scala:17)
	at org.apache.daffodil.util.CheckJavaVersion$.checkJavaVersion(CheckJavaVersion.scala:29)
	at org.apache.daffodil.compiler.ProcessorFactory$$anonfun$onPath$1.apply(Compiler.scala:166)
	at org.apache.daffodil.compiler.ProcessorFactory$$anonfun$onPath$1.apply(Compiler.scala:149)
	at scala.util.DynamicVariable.withValue(DynamicVariable.scala:58)
	at org.apache.daffodil.ExecutionMode$$anonfun$usingCompilerMode$1.apply(ExecutionMode.scala:64)
	at org.apache.daffodil.ExecutionMode$$anonfun$usingCompilerMode$1.apply(ExecutionMode.scala:64)
	at org.apache.daffodil.compiler.ProcessorFactory.onPath(Compiler.scala:149)
	at org.apache.daffodil.Main$$anonfun$71.apply(Main.scala:714)
	at org.apache.daffodil.Main$$anonfun$71.apply(Main.scala:711)
	at org.apache.daffodil.util.Timer$.getTimeResult(Timer.scala:76)
	at org.apache.daffodil.util.Timer$.getResult(Timer.scala:35)
	at org.apache.daffodil.Main$.createProcessorFromSchema(Main.scala:711)
	at org.apache.daffodil.Main$.run(Main.scala:824)
	at org.apache.daffodil.Main$.main(Main.scala:1297)
	at org.apache.daffodil.Main.main(Main.scala)

It looks like Java changed their version schema to not use a dot (e.g. 10 vs 1.10) and Scala 2.11's checker could handle that, so a NumberFormatException is thrown.

It looks like scala 2.12 has better checking for this (see DAFFODIL-1652), but we should also catch a NumberFormatException here and treat that as if it is not a valid Java version.

This was reported on Java 10, but I suspect the same issues happens for Java 9. Also, we should run our tests on Java 9/10 to ensure tests still pass with a newer Java.