[DAFFODIL-1435] Performance: avoid allocating String just to pass to trimByJustification

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Component/s: Back End, Performance
• Assignee: Unassigned
• Reporter: Mike Beckerle
• Created: 29/Oct/15 03:53
• Updated: 16/Dec/20 20:05
• Resolved: 16/Dec/20 20:05

Description

Why do we construct the string here? We could do the trim on the string buffer, (avoiding allocations), and have the trim call return the string itself. (Saves one string copy.)

There's another place where trimByJustification is called, on the result of DataInputStream.getSomeString(...).

Really that should return a StringBuilder so that trim can happen in-place.