[DAEMON-394] Monitor application will update multi-string values in Windows registry with blank lines

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.0
• Fix Version/s: 1.2.0
• Component/s: Procrun
• Labels: windows

Environment

OS: Windows 7 Pro, Service Pack 1

• Assignee: Unassigned
• Reporter: Brandon
• Created: 02/Nov/18 20:19
• Updated: 04/Jul/19 13:12
• Resolved: 11/Jun/19 10:58

Description

The Procrun Monitor application does not prevent a user from accidentally inserting blank lines into the Java Options or Java 9 Options text areas. If a blank line is introduced into either text area and the changes are applied (by hitting the Apply or OK button), the changes are committed to the associating multi-string value in the Windows registry.

If a user were to relaunch the Monitor application and view the Java or Java 9 Options again, they would see that the content has been truncated. Individual options above the blank line remain; any below are not present. If the Windows Registry editor were used to view the associating multi-string value, the user would see all of the content including the blank line.

Changing the options again from within the Monitor application will succeed but when the options are committed to the registry multi-string value, any options that existed below the blank line will be removed.

Note that the Windows registry editor will display an error dialog if a user attempts to save a multi-string value with an empty line present. The message is: "Data of type REG_MULTI_SZ cannot contain empty strings. Registry Editor will remove all empty strings found."

Steps to Reproduce:

1. Download latest Commons Daemon distribution for windows (1.1.0).
2. Run prunsrv.exe to install a test service (TestService).
3. Run prunmgr.exe //ES/TestService to start the monitor application to edit the same TestService.
4. Switch to the Java tab and edit either the Java Options or Java 9 Options. Insert a bunch of options and then Insert a blank line somewhere in-between those options. Click OK
5. Run prunmgr again. Look at the Java Options or Java 9 Options where the blank line was inserted. Notice that all options below the blank line are not visible.
6. Open up the registry editor and navigate to the multi-string value associated with the Java Options text area: HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Apache Software Foundation\Procrun 2.0\TestService\Parameters\Java
7. Notice that all content is present (including the blank line) in the registry value.