Commons Daemon
  1. Commons Daemon
  2. DAEMON-226

support files have incorrect svn:eol-style

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: Nightly Builds
    • Fix Version/s: None
    • Component/s: Jsvc
    • Labels:
      None

      Description

      I have checked out under Windows and copied an exported tar to a unix system. All files contained ^M. This is not a issue if you checkout under Unix but in my case I do not have an svn client and have to do this way.

      Anyway, the eol-style should always be LF because these files are for Unix only.
      I have attached a patch for.

      1. DAEMON-226.patch
        1 kB
        Michael Osipov

        Activity

        Michael Osipov created issue -
        Michael Osipov made changes -
        Field Original Value New Value
        Attachment DAEMON-226.patch [ 12501750 ]
        Hide
        Mladen Turk added a comment -

        EOL style is used when on the same platform certain files need to have different line endings. This is not case here.
        In your case you can use either dos2unix or svn export --native-eol LF.

        Show
        Mladen Turk added a comment - EOL style is used when on the same platform certain files need to have different line endings. This is not case here. In your case you can use either dos2unix or svn export --native-eol LF.
        Mladen Turk made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Won't Fix [ 2 ]
        Hide
        Michael Osipov added a comment -

        Well, this is a Unix file shouldn't this always be in LF line endings just to avoid confusions?!

        Show
        Michael Osipov added a comment - Well, this is a Unix file shouldn't this always be in LF line endings just to avoid confusions?!
        Hide
        Sebb added a comment -

        I'm inclined to agree with the originator here.

        If it helps some users, and does not cause problems for others, why not set a fixed EOL style?

        Show
        Sebb added a comment - I'm inclined to agree with the originator here. If it helps some users, and does not cause problems for others, why not set a fixed EOL style?
        Hide
        Mladen Turk added a comment -

        There are many more files that would have to be changed (almost entire unix directory).
        Even if checking out on windows and compiling on linux (come on lets get serious)
        user has multiple choices from selecting the exported line ending to using cygwin svn
        I'll -1 such attempt cause there's no technical reason for such a change.

        Show
        Mladen Turk added a comment - There are many more files that would have to be changed (almost entire unix directory). Even if checking out on windows and compiling on linux (come on lets get serious) user has multiple choices from selecting the exported line ending to using cygwin svn I'll -1 such attempt cause there's no technical reason for such a change.
        Hide
        Michael Osipov added a comment -

        Mladen, actually not. Only /bin/sh expects LF formatted files. C and H files are irrelevant.

        Show
        Michael Osipov added a comment - Mladen, actually not. Only /bin/sh expects LF formatted files. C and H files are irrelevant.

          People

          • Assignee:
            Unassigned
            Reporter:
            Michael Osipov
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development