[CXF-8587] Don't check the validation flag and get the schema on every iteration for SoapHeader

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.4, 3.3.11
• Fix Version/s: 3.5.0, 3.3.12, 3.4.5
• Component/s: Soap Binding
• Estimated Complexity: Unknown
• Assignee: Unassigned
• Reporter: Ilya Mikhailov
• Created: 29/Aug/21 06:07
• Updated: 22/Dec/21 20:41
• Resolved: 30/Aug/21 19:11

Description

It seems like we don't need to check the schema enabled flag and get schema on every iteration for a SoapHeder.

for (SoapHeaderInfo header : headers) {
    MessagePartInfo mpi = header.getPart();
    try {
        if (ServiceUtils.isSchemaValidationEnabled(SchemaValidationType.IN, message)) {
            Schema schema = EndpointReferenceUtils.getSchema(service.getServiceInfos().get(0), message
                                                             .getExchange().getBus());
            validateHeader(message, mpi, schema);
        }
    } catch (Fault f) {
        if (!isRequestor(message)) {
            f.setFaultCode(Fault.FAULT_CODE_CLIENT);
        }
        throw f;
    }
    ...
}

Removing these actions outside of the loop can provide a slight performance improvement if multiple headers are present in a request.

Issue Links

• links to: GitHub Pull Request #839