[CXF-8169] CXF opentracing - Span#finish is never called in case of client timeouts

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.2.11, 3.3.4, 3.4.0
• Fix Version/s: 3.3.5, 3.2.12, 3.4.0
• Component/s: Tracing
• Estimated Complexity: Unknown
• Assignee: Andriy Redko
• Reporter: Baptiste AIGLIN
• Created: 29/Nov/19 13:54
• Updated: 15/Jan/20 10:23
• Resolved: 03/Dec/19 01:44

Description

While using the CXF opentracing feature with any CXF client, we see that in case of connectionTimeout or receiveTimeout the span#finish is never called by the OpenTracing client interceptors. We can clearly see that inside the OpenTracingClientStartInterceptor from the OpenTracingClientFeature there is no handleFault() method defined to handle such case.

I wrote the test allowing to reproduce this behavior using a JAX-RS client and a really simplistic fix on the CustomOpenTracingClientFeature where the current OpenTracingClientStartInterceptor is overriden in order to add such handleFault method and using the OpenTracingClientStopInterceptor#handleMethod in order to trigger the stop.

Thanks in advance for your feedback.