[CXF-8132] CXF metrics - No FaultMode in Exchange for response timeout during reception of payload

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Bug
• Affects Version/s: 3.1.18, 3.3.3
• Component/s: Core
• Estimated Complexity: Moderate
• Assignee: Andriy Redko
• Reporter: Emile de Weerd
• Created: 16/Oct/19 14:53
• Updated: 18/Sep/23 18:49
• Resolved: 29/Dec/19 21:59

Description

While using the CXF metrics feature with a CXF REST client, in some error case there is not FaultMode inside the Exchange object passed to the MetricsContext#stop method. The use case is when the response body transmission is interrupted in the middle of the transfer.

I wrote a unit test that allows to clearly reproduce. It is failing. The Unit test prints out stacktraces whenever start or stop are called from the MetricsContext.

incompleteResponse_stopCalledOnceWithFaultObjectInExchange

[main] INFO cxf.reproducers.CxfMetricsIssueReproducerTest - MetricsContext#stop called 1 times
[main] INFO cxf.reproducers.CxfMetricsIssueReproducerTest - - stop called with time = 14901568 ns, inSize = -1, outSize = 0, exchange that contains a FaultMode = false; callad at:
[...]
at org.apache.cxf.metrics.MetricsContext$$EnhancerByMockitoWithCGLIB$$1997d2d2.stop(<generated>)
at org.apache.cxf.metrics.ExchangeMetrics.stop(ExchangeMetrics.java:75)
at org.apache.cxf.metrics.interceptors.AbstractMetricsInterceptor.stop(AbstractMetricsInterceptor.java:215)
at org.apache.cxf.metrics.interceptors.MetricsMessageInPostInvokeInterceptor.handleMessage(MetricsMessageInPostInvokeInterceptor.java:34)
at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)
at org.apache.cxf.jaxrs.client.ClientMessageObserver.onMessage(ClientMessageObserver.java:56)
at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponseInternal(HTTPConduit.java:1693)
at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponse(HTTPConduit.java:1570)
at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.close(HTTPConduit.java:1371)
at org.apache.cxf.io.AbstractWrappedOutputStream.close(AbstractWrappedOutputStream.java:77)
at org.apache.cxf.metrics.interceptors.CountingOutputStream.close(CountingOutputStream.java:47)
at org.apache.cxf.transport.AbstractConduit.close(AbstractConduit.java:56)
at org.apache.cxf.transport.http.HTTPConduit.close(HTTPConduit.java:671)
at org.apache.cxf.interceptor.MessageSenderInterceptor$MessageSenderEndingInterceptor.handleMessage(MessageSenderInterceptor.java:63)
at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)
at org.apache.cxf.jaxrs.client.AbstractClient.doRunInterceptorChain(AbstractClient.java:709)
at org.apache.cxf.jaxrs.client.ClientProxyImpl.doChainedInvocation(ClientProxyImpl.java:887)
at org.apache.cxf.jaxrs.client.ClientProxyImpl.invoke(ClientProxyImpl.java:335)
at com.sun.proxy.$Proxy22.getBook(Unknown Source)
at cxf.reproducers.CxfMetricsIssueReproducerTest.incompleteResponse_stopCalledOnceWithFaultObjectInExchange(CxfMetricsIssueReproducerTest.java:171)
[...]

I am not sure the test case makes sense, maybe that is the first part to review.

Issue Links

• is a clone of: CXF-8124 CXF metrics - MetricsContext#stop called twice or without Fault in certain error cases