[CXF-8087] unstable test environment caused by accessing system property without cleanup

• Type: Test
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.3.2
• Fix Version/s: 3.3.4
• Component/s: JAX-RS
• Labels: test
• Estimated Complexity: Unknown
• Assignee: Colm O hEigeartaigh
• Reporter: zi peng
• Created: 07/Aug/19 20:09
• Updated: 22/Dec/21 20:43
• Resolved: 22/Aug/19 12:17

Description

JAXRSclientServerWebSocketTest is inherited by several tests. In one of its child tests( i.e. JAXRSClientServerWebSocketNoAtmosphereTest), system property is set to true in the test fixture.  However, none test cases or fixture reset the modified system property after the completion of a test run. 

Result: test results may become flaky and unstable in multiple test runs

 

public class JAXRSClientServerWebSocketNoAtmosphereTest extends JAXRSClientServerWebSocketTest {	
    @BeforeClass
    public static void startServers() throws Exception {
	System.setProperty("org.apache.cxf.transport.websocket.atmosphere.disabled", "true");
	AbstractResourceInfo.clearAllMaps();
	assertTrue("server did not launch correctly", launchServer(new BookServerWebSocket(PORT)));
	createStaticBus();
    }
	
    @AfterClass
    public static void cleanup() {
	//System.clearProperty("org.apache.cxf.transport.websocket.atmosphere.disabled");
    }