[CXF-7844] Change Zipkin/Brave XML to use brave-spring-beans

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.1.17, 3.2.7, 3.3.0
• Component/s: Tracing Brave
• Estimated Complexity: Unknown
• Assignee: Andriy Redko
• Reporter: Adrian Cole
• Created: 14/Sep/18 07:43
• Updated: 03/Oct/18 13:33
• Resolved: 29/Sep/18 00:13

Description

I noticed the sample projects don't connect to any server. This could make it hard for someone to get started. Also, the XML beans don't use the helpers that exist in brave.

https://github.com/apache/cxf/tree/master/distribution/src/main/release/samples/jax_rs/tracing_brave
https://github.com/apache/cxf/tree/master/distribution/src/main/release/samples/jax_rs/tracing_brave_osgi
https://github.com/apache/cxf/tree/master/distribution/src/main/release/samples/jaxws_tracing_brave_osgi

Could these be changed to use brave-spring-beans? or otherwise make a functional tracer? https://github.com/openzipkin/brave/tree/master/spring-beans

Here are some example configurations:
https://github.com/openzipkin/brave-webmvc-example/blob/master/webmvc3/src/main/webapp/WEB-INF/applicationContext.xml
https://github.com/openzipkin/brave-webmvc-example/blob/master/webmvc4-boot/src/main/java/brave/webmvc/TracingConfiguration.java

Issue Links

• is related to: CXF-7855 Update the Brave/OpenTracing/HTrace documentation to include more code snippets