Uploaded image for project: 'CXF'
  1. CXF
  2. CXF-7042

review some jaxrs client defaults: thread safe and split headers

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: JAX-RS
    • Labels:
      None
    • Estimated Complexity:
      Unknown

      Description

      Hi

      putting it as "bug" but can be "improvement" depending how you see it

      I'd like we take a moment to review 2 properties of the client:

      • thread.safe.client: i think the default should be true since the spec is thread safe
      • org.apache.cxf.http.header.split (AbstractClient): issue not being true by default is it breaks some natural JAXRS round trips like Link: your server sends Link header with 2 values, client (response.getLinks()) is not able to read it. If it is about performances, known headers (the ones wrapped by some higher level API in JAXRS) should at least be handled properly by default.

      Side note for headers: org.apache.cxf.transport.http.Headers#copyToResponse concatenate headers properly for multiple values but not for Link header cause of org.apache.cxf.transport.http.Headers#HTTP_HEADERS_SINGLE_VALUE_ONLY, not sure it is intended

      wdyt?

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              romain.manni-bucau Romain Manni-Bucau
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: